Add pallet connectors gateway #1376

cdamian · 2023-05-30T15:27:21Z

Description

This PR adds the Connectors Gateway pallet which will be used to process inbound and outbound Connectors messages.

Changes and Descriptions

Connectors Gateway pallet - entrypoint for Connectors messages that's using the InboundQueue for processing incoming messages in the case of successful validation, and that implements the OutboundQueue for processing outgoing messages that are handled by the according XCM or EVM router.
Connectors Gateway routers - separate crate that's part of the Connectors Gateway pallet which holds the routers that are used in the gateway.

Checklist:

I have added Rust doc comments to structs, enums, traits and functions
I have made corresponding changes to the documentation
I have performed a self-review of my code
I have added tests that prove my fix is effective or that my feature works

pallets/connectors-gateway/connectors-gateway-routers/src/axelar_evm.rs

lemunozm

A couple of comments about mocking, but looks quite good!

libs/mocks/src/connectors.rs

lemunozm · 2023-06-02T10:55:10Z

libs/mocks/src/connectors.rs

+#[derive(Debug, Eq, PartialEq)]
+pub enum MessageMock {
+	First,
+	Second,
+}
+
+impl MessageMock {
+	fn call_type(&self) -> u8 {
+		match self {
+			MessageMock::First => 0,
+			MessageMock::Second => 1,
+		}
+	}
+}
+
+impl Codec for MessageMock {
+	fn serialize(&self) -> Vec<u8> {
+		vec![self.call_type()]
+	}
+
+	fn deserialize<I: Input>(input: &mut I) -> Result<Self, Error> {
+		let call_type = input.read_byte()?;
+
+		match call_type {
+			0 => Ok(MessageMock::First),
+			1 => Ok(MessageMock::Second),
+			_ => Err("unsupported message".into()),
+		}
+	}
+}


Maybe I'm going too far, but maybe a simple number can be used as a message to avoid this type?

An later use something like:

domain_router.send(sender, 42).unwrap()

That simple type wouldn't implement the Codec trait, some boilerplate might still be needed regardless.

Mmm... that's weird 🤔 . I'm pretty sure Codec and Serialize is implemented for basic types. Could it be because the compiler doesn't know exactly what that 42 is? Sometimes in these cases, you need to help the compiler with something like 42u32.

You are probably referring to a different Codec trait, I'm referring to the one that we have in connectors - https://github.com/centrifuge/centrifuge-chain/blob/add-pallet-connectors-gateway/libs/traits/src/connectors.rs#L19

Ouch, you're right! Never mind then

Although... would it make sense to add the basic types to the Codec trait along with the implementation (as it happens with the substrate Codec and Serialize traits)? @NunoAlexandre @wischli

pallets/connectors-gateway/connectors-gateway-routers/src/ethereum_xcm.rs

pallets/ethereum-transaction/src/lib.rs

mustermeiszer · 2023-06-30T09:15:05Z

Coming back to this: #1403 (comment)

I think we will just benchmark the call as we usually do. IIUC this will result in the caller having to pay fees twice. For now I think it is fine, we must just create a todo to fix this!

The only thing we must ensure is that these lines

// Use the same conversion as the one used in `EnsureAddressTruncated`.
let sender_evm_address = H160::from_slice(&sender.as_ref()[0..20]);

create the backwards conversion to the mapping that type AddressMapping: AddressMapping<Self::AccountId>; is doing. So we need roundtripping for that.

cc @branan for consolidation.

runtime/development/src/lib.rs

NunoAlexandre

One suggestion 👀

pallets/connectors-gateway/src/lib.rs

mustermeiszer

LGTM!

mustermeiszer · 2023-07-13T10:29:55Z

Failing tests can be fixed by applying the latest changes of the precompile branch here. I just do not wnat the node changes in this PR. THe latest precompile stuff can already be included.

* gateway: Move domain routers to runtime * gateway-routers: Move to separate crate * runtime: Remove unused deps * traits: Add more comments to Router trait, rename forward to send * connectors-gateway: Rename routers crate, use ensure! for validation * connectors: Rename submit to handle * connectors-gateway: Drop max message const, use Vec instead * connectors-gateway: Rename router and queues methods * connectors-gateway: Update edition to 2021 * gateway-routers: Drop wildcard import * connectors-gateway: Rename DomainSubmitters to ConnectorsAllowlist and associated types * connectors-gateway: Add missing features * connectors-gateway: Update deps and runtime config

…sts.

* pallets: Add Ethereum Transaction pallet * ethereum-transaction: Drop origin * ethereum-transaction: Drop weights and origin type * ethereum-transaction: Handle call info exit reasons

mustermeiszer

Not an perfect in debth review, but I have seen this PR before and it still looks good. Great work again @cdamian!

But would be good to get another pair of eyes on this at least! ^^

cdamian · 2023-07-14T11:47:00Z

This PR will be split into multiple smaller PRs that focus on one part.

cdamian · 2023-07-14T11:47:17Z

Part 1 - adding Connectors Gateway pallet - #1456
Part 2 - adding Ethereum Transaction pallet - #1460
Part 3 - adding Connectors Gateway routers - #1475
Part 4 - integration tests for all of the above - #1478

NunoAlexandre · 2023-07-31T15:24:49Z

@cdamian do we want to close this?

cdamian · 2023-07-31T15:26:06Z

@cdamian do we want to close this?

@NunoAlexandre Let's keep it open until we merge all remaining parts, it's also helpful for me to keep track of things ^^

NunoAlexandre · 2023-07-31T15:28:15Z

@cdamian do we want to close this?

@NunoAlexandre Let's keep it open until we merge all remaining parts, it's also helpful for me to keep track of things ^^

Sure, I was just trying to follow these gateway-related PRs an given your comments [https://github.com//pull/1376#issuecomment-1635746946] above I thought this PR was now obsolete given those two Parts have been merged already 👍

cdamian · 2023-07-31T15:29:20Z

@cdamian do we want to close this?

@NunoAlexandre Let's keep it open until we merge all remaining parts, it's also helpful for me to keep track of things ^^

Sure, I was just trying to follow these gateway-related PRs an given your comments [https://github.com//pull/1376#issuecomment-1635746946] above I thought this PR was now obsolete given those two Parts have been merged already +1

I will document all following PRs here then close it when everything is done.

NunoAlexandre · 2023-07-31T15:31:06Z

@cdamian do we want to close this?

@NunoAlexandre Let's keep it open until we merge all remaining parts, it's also helpful for me to keep track of things ^^

Sure, I was just trying to follow these gateway-related PRs an given your comments [https://github.com//pull/1376#issuecomment-1635746946] above I thought this PR was now obsolete given those two Parts have been merged already +1

I will document all following PRs here then close it when everything is done.

Sweet, thanks and sorry for the unintentional noise :)

cdamian · 2023-08-10T12:34:36Z

Closing this since the last related PR was just merged. Other work related to the topic, such as the precompiles will be done separately and documented accordingly.

cdamian commented May 30, 2023

View reviewed changes

pallets/connectors-gateway/connectors-gateway-routers/src/axelar_evm.rs Outdated Show resolved Hide resolved

lemunozm reviewed Jun 2, 2023

View reviewed changes

cdamian force-pushed the add-pallet-connectors-gateway branch from 5a61d40 to 645b3a4 Compare June 15, 2023 16:00

cdamian mentioned this pull request Jun 15, 2023

pallets: Add Ethereum Transaction pallet #1403

Merged

wischli mentioned this pull request Jun 16, 2023

feat: add connectors v2 extrinsics & inbound msg handlers #1364

Merged

15 tasks

NunoAlexandre mentioned this pull request Jun 16, 2023

xcm-router: Update message_length_scale_encoded centrifuge/liquidity-pools#68

Closed

cdamian force-pushed the add-pallet-connectors-gateway branch from 29ff74c to f95c168 Compare June 23, 2023 15:34

cdamian commented Jun 26, 2023

View reviewed changes

pallets/connectors-gateway/connectors-gateway-routers/src/ethereum_xcm.rs Show resolved Hide resolved

cdamian commented Jun 27, 2023

View reviewed changes

pallets/ethereum-transaction/src/lib.rs Show resolved Hide resolved

cdamian commented Jul 6, 2023

View reviewed changes

runtime/development/src/lib.rs Outdated Show resolved Hide resolved

NunoAlexandre reviewed Jul 7, 2023

View reviewed changes

pallets/connectors-gateway/src/lib.rs Outdated Show resolved Hide resolved

pallets/connectors-gateway/src/lib.rs Outdated Show resolved Hide resolved

cdamian force-pushed the add-pallet-connectors-gateway branch from 2452e2f to 241d0e2 Compare July 11, 2023 13:38

mustermeiszer previously approved these changes Jul 13, 2023

View reviewed changes

cdamian dismissed mustermeiszer’s stale review via 765a286 July 13, 2023 11:05

cdamian added 14 commits July 13, 2023 20:56

connectors-gateway: Add initial pallet and traits

951aac3

wip: Copy XCM transactor logic from connectors

5468d59

connectors-gateway: Rename moonbeam to ethereum_xcm

f80b70d

gateway-routers: Add first version of Axelar EVM router

3b0e9eb

gateway-routers: Clean-up TODOs

fea0da1

connectors-gateway: Add tests for pallet, prepare setup for router te…

4386a63

…sts.

runtime: Fix imports

ea961cf

wip: WIP

97c29a9

task: Rebase on latest main

ff3f315

pallets: Add Ethereum Transaction pallet (#1403)

b626199

* pallets: Add Ethereum Transaction pallet * ethereum-transaction: Drop origin * ethereum-transaction: Drop weights and origin type * ethereum-transaction: Handle call info exit reasons

connectors-gateway: Add more unit tests

2d0bc1c

runtime: Add pallet-ethereum-transaction

e680c96

libs: Add pallet-ethereum-transaction mocks, update router mock

8a69030

cdamian added 8 commits July 13, 2023 20:56

gateway-routers: Add check for contract code in Axelar router

ca5982e

gateway: Use StorageDoubleMap for ConnectorsAllowlist

4316165

gateway: Update precompile

23e41ac

taplo: Obey

dff40c6

deps: Use moonbeam EVM-related deps instead of parity

3706f52

gatway: Fix docs link

612a5dd

taplo: Fix

1ad7120

clippy: Fix warning

ac8cb63

cdamian force-pushed the add-pallet-connectors-gateway branch from 40434f5 to ac8cb63 Compare July 13, 2023 17:56

cdamian marked this pull request as ready for review July 13, 2023 18:03

cdamian requested review from wischli, mikiquantum and thea-leake as code owners July 13, 2023 18:03

mustermeiszer added the D0-ready Pull request can be merged without special precaution and notification. label Jul 13, 2023

docs: Add more docs around gateway pallets and routers

8d9dd50

mustermeiszer approved these changes Jul 13, 2023

View reviewed changes

cdamian mentioned this pull request Jul 14, 2023

connectors-gateway: Add gateway pallet #1456

Merged

4 tasks

cdamian marked this pull request as draft July 14, 2023 11:47

cdamian mentioned this pull request Jul 18, 2023

connectors-gateway: Add Ethereum Transaction pallet #1460

Merged

4 tasks

cdamian mentioned this pull request Aug 1, 2023

connectors-gateway: Add gateway routers #1475

Merged

4 tasks

cdamian closed this Aug 10, 2023

cdamian deleted the add-pallet-connectors-gateway branch July 30, 2024 07:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add pallet connectors gateway #1376

Add pallet connectors gateway #1376

cdamian commented May 30, 2023 •

edited

Loading

lemunozm left a comment

lemunozm Jun 2, 2023

cdamian Jun 13, 2023

lemunozm Jun 13, 2023

cdamian Jun 13, 2023

lemunozm Jun 13, 2023

lemunozm Jun 13, 2023 •

edited

Loading

mustermeiszer commented Jun 30, 2023

NunoAlexandre left a comment

mustermeiszer left a comment

mustermeiszer commented Jul 13, 2023

mustermeiszer left a comment

cdamian commented Jul 14, 2023

cdamian commented Jul 14, 2023 •

edited

Loading

NunoAlexandre commented Jul 31, 2023

cdamian commented Jul 31, 2023

NunoAlexandre commented Jul 31, 2023

cdamian commented Jul 31, 2023

NunoAlexandre commented Jul 31, 2023

cdamian commented Aug 10, 2023

Add pallet connectors gateway #1376

Add pallet connectors gateway #1376

Conversation

cdamian commented May 30, 2023 • edited Loading

Description

Changes and Descriptions

Checklist:

lemunozm left a comment

Choose a reason for hiding this comment

lemunozm Jun 2, 2023

Choose a reason for hiding this comment

cdamian Jun 13, 2023

Choose a reason for hiding this comment

lemunozm Jun 13, 2023

Choose a reason for hiding this comment

cdamian Jun 13, 2023

Choose a reason for hiding this comment

lemunozm Jun 13, 2023

Choose a reason for hiding this comment

lemunozm Jun 13, 2023 • edited Loading

Choose a reason for hiding this comment

mustermeiszer commented Jun 30, 2023

NunoAlexandre left a comment

Choose a reason for hiding this comment

mustermeiszer left a comment

Choose a reason for hiding this comment

mustermeiszer commented Jul 13, 2023

mustermeiszer left a comment

Choose a reason for hiding this comment

cdamian commented Jul 14, 2023

cdamian commented Jul 14, 2023 • edited Loading

NunoAlexandre commented Jul 31, 2023

cdamian commented Jul 31, 2023

NunoAlexandre commented Jul 31, 2023

cdamian commented Jul 31, 2023

NunoAlexandre commented Jul 31, 2023

cdamian commented Aug 10, 2023

cdamian commented May 30, 2023 •

edited

Loading

lemunozm Jun 13, 2023 •

edited

Loading

cdamian commented Jul 14, 2023 •

edited

Loading